Skip to content

Add JSON file attached message to submission emails#1741

Merged
SamJamCul merged 2 commits intomainfrom
update-email-submission-body-for-json-submissions
Nov 18, 2025
Merged

Add JSON file attached message to submission emails#1741
SamJamCul merged 2 commits intomainfrom
update-email-submission-body-for-json-submissions

Conversation

@SamJamCul
Copy link
Copy Markdown
Contributor

@SamJamCul SamJamCul commented Nov 18, 2025 •
edited
Loading

What problem does this pull request solve?

https://trello.com/c/xirVFN8l/2653-update-email-submission-body-for-json-submissions

Adds a line to the submission email which will appear when a json file is being attached.

Also adds a README to the mailer preview to remind us how to view them.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@SamJamCul SamJamCul force-pushed the update-email-submission-body-for-json-submissions branch from 4f3bc95 to 76dcf5f Compare November 18, 2025 13:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 18, 2025

🎉 A review copy of this PR has been deployed! It is made of up two components

  1. A review copy of forms-runner
  2. A production copy of forms-admin

Important

Not all of the functionality of forms-runner is present in review apps.
Functionality such as sending emails, file upload, and S3 submission types are
deliberately disabled for the sake of simplifying review apps.

You should use the full dev environment to test the functionality which is disabled here.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@SamJamCul SamJamCul force-pushed the update-email-submission-body-for-json-submissions branch from d240ad2 to 645f95f Compare November 18, 2025 13:59
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 18, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

stephencdaly
stephencdaly approved these changes Nov 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@stephencdaly stephencdaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected

@SamJamCul SamJamCul merged commit c800018 into main Nov 18, 2025
5 of 6 checks passed
@SamJamCul SamJamCul deleted the update-email-submission-body-for-json-submissions branch November 18, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephencdaly stephencdaly stephencdaly approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SamJamCul @stephencdaly